[Python-checkins] bpo-44022: Improve the regression test. (GH-26503) (GH-26507)

ned-deily webhook-mailer at python.org
Thu Jun 3 00:23:49 EDT 2021


https://github.com/python/cpython/commit/fee96422e6f0056561cf74fef2012cc066c9db86
commit: fee96422e6f0056561cf74fef2012cc066c9db86
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: ned-deily <nad at python.org>
date: 2021-06-03T00:23:40-04:00
summary:

bpo-44022: Improve the regression test. (GH-26503) (GH-26507)

It wasn't actually detecting the regression due to the
assertion being too lenient.
(cherry picked from commit e60ab843cbb016fb6ff8b4f418641ac05a9b2fcc)

Co-authored-by: Gregory P. Smith <greg at krypto.org>

files:
M Lib/test/test_httplib.py

diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py
index 8333aa0eeef6ac..a65044eea60dc0 100644
--- a/Lib/test/test_httplib.py
+++ b/Lib/test/test_httplib.py
@@ -1004,7 +1004,12 @@ def test_overflowing_header_limit_after_100(self):
             'r\n' * 32768
         )
         resp = client.HTTPResponse(FakeSocket(body))
-        self.assertRaises(client.HTTPException, resp.begin)
+        with self.assertRaises(client.HTTPException) as cm:
+            resp.begin()
+        # We must assert more because other reasonable errors that we
+        # do not want can also be HTTPException derived.
+        self.assertIn('got more than ', str(cm.exception))
+        self.assertIn('headers', str(cm.exception))
 
     def test_overflowing_chunked_line(self):
         body = (



More information about the Python-checkins mailing list