[Python-checkins] bpo-44342: [Enum] fix data type search (GH-26667)
ethanfurman
webhook-mailer at python.org
Fri Jun 11 04:25:30 EDT 2021
https://github.com/python/cpython/commit/3a7cccfd6cd3693e1a2ab65ee05d7f45f8501dfa
commit: 3a7cccfd6cd3693e1a2ab65ee05d7f45f8501dfa
branch: main
author: Ethan Furman <ethan at stoneleaf.us>
committer: ethanfurman <ethan at stoneleaf.us>
date: 2021-06-11T01:25:14-07:00
summary:
bpo-44342: [Enum] fix data type search (GH-26667)
In an inheritance chain of
int -> my_int -> final_int
the data type is now final_int (not my_int)
files:
M Lib/enum.py
M Lib/test/test_enum.py
diff --git a/Lib/enum.py b/Lib/enum.py
index 5263e510d5936..5548130be34d4 100644
--- a/Lib/enum.py
+++ b/Lib/enum.py
@@ -818,7 +818,7 @@ def _find_data_type(bases):
data_types.add(candidate or base)
break
else:
- candidate = base
+ candidate = candidate or base
if len(data_types) > 1:
raise TypeError('%r: too many data types: %r' % (class_name, data_types))
elif data_types:
diff --git a/Lib/test/test_enum.py b/Lib/test/test_enum.py
index 9a7882b8a9c6f..22a829d102041 100644
--- a/Lib/test/test_enum.py
+++ b/Lib/test/test_enum.py
@@ -658,6 +658,14 @@ class MyEnum(HexInt, enum.Enum):
def __repr__(self):
return '<%s.%s: %r>' % (self.__class__.__name__, self._name_, self._value_)
self.assertEqual(repr(MyEnum.A), '<MyEnum.A: 0x1>')
+ #
+ class SillyInt(HexInt):
+ pass
+ class MyOtherEnum(SillyInt, enum.Enum):
+ D = 4
+ E = 5
+ F = 6
+ self.assertIs(MyOtherEnum._member_type_, SillyInt)
def test_too_many_data_types(self):
with self.assertRaisesRegex(TypeError, 'too many data types'):
More information about the Python-checkins
mailing list