[Python-checkins] bpo-40128: Fix IDLE autocomplete on macOS (GH-26672)

terryjreedy webhook-mailer at python.org
Fri Jun 11 19:24:24 EDT 2021


https://github.com/python/cpython/commit/b441e99d89a3f05210cc36ade57699384986ca00
commit: b441e99d89a3f05210cc36ade57699384986ca00
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: terryjreedy <tjreedy at udel.edu>
date: 2021-06-11T19:24:16-04:00
summary:

bpo-40128: Fix IDLE autocomplete on macOS (GH-26672)

In particular, when running with tk8.6.8, as in PSF 3.9.

Co-authored-by: Terry Jan Reedy <tjreedy at udel.edu>
(cherry picked from commit 3ec3ee7d2e9b45b586e486e429b412d6d0ca530f)

Co-authored-by: Kaustubh J <kaustubhkj at gmail.com>

files:
A Misc/NEWS.d/next/IDLE/2021-06-11-17-43-39.bpo-40128.7vDN3U.rst
M Lib/idlelib/autocomplete_w.py

diff --git a/Lib/idlelib/autocomplete_w.py b/Lib/idlelib/autocomplete_w.py
index 2e3f9c14a1981..13ff60ae4493e 100644
--- a/Lib/idlelib/autocomplete_w.py
+++ b/Lib/idlelib/autocomplete_w.py
@@ -206,6 +206,7 @@ def show_window(self, comp_lists, index, complete, mode, userWantsWin):
         scrollbar.config(command=listbox.yview)
         scrollbar.pack(side=RIGHT, fill=Y)
         listbox.pack(side=LEFT, fill=BOTH, expand=True)
+        acw.update_idletasks() # Need for tk8.6.8 on macOS: #40128.
         acw.lift()  # work around bug in Tk 8.5.18+ (issue #24570)
 
         # Initialize the listbox selection
diff --git a/Misc/NEWS.d/next/IDLE/2021-06-11-17-43-39.bpo-40128.7vDN3U.rst b/Misc/NEWS.d/next/IDLE/2021-06-11-17-43-39.bpo-40128.7vDN3U.rst
new file mode 100644
index 0000000000000..dafbe2cd5c3a8
--- /dev/null
+++ b/Misc/NEWS.d/next/IDLE/2021-06-11-17-43-39.bpo-40128.7vDN3U.rst
@@ -0,0 +1,3 @@
+Mostly fix completions on macOS when not using tcl/tk 8.6.11 (as with 3.9).
+The added update_idletask call should be harmless and possibly helpful
+otherwise.



More information about the Python-checkins mailing list