[Python-checkins] bpo-43162: [Enum] update docs, renable doc tests (GH-24487)
ethanfurman
webhook-mailer at python.org
Wed Mar 3 12:54:38 EST 2021
https://github.com/python/cpython/commit/44e580f448016b86807465a186d03d9074e2b589
commit: 44e580f448016b86807465a186d03d9074e2b589
branch: master
author: Ethan Furman <ethan at stoneleaf.us>
committer: ethanfurman <ethan at stoneleaf.us>
date: 2021-03-03T09:54:30-08:00
summary:
bpo-43162: [Enum] update docs, renable doc tests (GH-24487)
* update docs, renable doc tests
* make deprecation warning active for two releases
files:
M Doc/library/enum.rst
M Lib/enum.py
M Lib/test/test_enum.py
diff --git a/Doc/library/enum.rst b/Doc/library/enum.rst
index b7f269464e794..73b77cbc671cd 100644
--- a/Doc/library/enum.rst
+++ b/Doc/library/enum.rst
@@ -1222,17 +1222,18 @@ Private names are not converted to Enum members, but remain normal attributes.
:class:`Enum` members are instances of their :class:`Enum` class, and are
normally accessed as ``EnumClass.member``. In Python versions ``3.5`` to
``3.9`` you could access members from other members -- this practice was
-discouraged, and in ``3.10`` :class:`Enum` has returned to not allowing it::
+discouraged, and in ``3.12`` :class:`Enum` will return to not allowing it,
+while in ``3.10`` and ``3.11`` it will raise a :exc:`DeprecationWarning`::
>>> class FieldTypes(Enum):
... name = 0
... value = 1
... size = 2
...
- >>> FieldTypes.value.size
- Traceback (most recent call last):
- ...
- AttributeError: FieldTypes: no attribute 'size'
+ >>> FieldTypes.value.size # doctest: +SKIP
+ DeprecationWarning: accessing one member from another is not supported,
+ and will be disabled in 3.12
+ <FieldTypes.size: 2>
.. versionchanged:: 3.5
.. versionchanged:: 3.10
diff --git a/Lib/enum.py b/Lib/enum.py
index 55299c5788244..84c7b0dc2afbe 100644
--- a/Lib/enum.py
+++ b/Lib/enum.py
@@ -148,7 +148,7 @@ def __get__(self, instance, ownerclass=None):
import warnings
warnings.warn(
"accessing one member from another is not supported, "
- " and will be disabled in 3.11",
+ " and will be disabled in 3.12",
DeprecationWarning,
stacklevel=2,
)
diff --git a/Lib/test/test_enum.py b/Lib/test/test_enum.py
index 3982d1d643043..69392e01faacd 100644
--- a/Lib/test/test_enum.py
+++ b/Lib/test/test_enum.py
@@ -18,7 +18,7 @@
def load_tests(loader, tests, ignore):
tests.addTests(doctest.DocTestSuite(enum))
- if os.path.exists('../../Doc/library/enum.rst'):
+ if os.path.exists('Doc/library/enum.rst'):
tests.addTests(doctest.DocFileSuite(
'../../Doc/library/enum.rst',
optionflags=doctest.ELLIPSIS|doctest.NORMALIZE_WHITESPACE,
@@ -2186,7 +2186,7 @@ class Private(Enum):
self.assertEqual(Private._Private__major_, 'Hoolihan')
@unittest.skipUnless(
- sys.version_info[:2] == (3, 10),
+ sys.version_info[:2] < (3, 12),
'member-member access now raises an exception',
)
def test_warning_for_member_from_member_access(self):
@@ -2198,7 +2198,7 @@ class Di(Enum):
self.assertIs(Di.NO, nope)
@unittest.skipUnless(
- sys.version_info[:2] > (3, 10),
+ sys.version_info[:2] >= (3, 12),
'member-member access currently issues a warning',
)
def test_exception_for_member_from_member_access(self):
More information about the Python-checkins
mailing list