[Python-checkins] bpo-41718: libregrtest avoids importing datetime (GH-24985)
vstinner
webhook-mailer at python.org
Mon Mar 22 20:40:47 EDT 2021
https://github.com/python/cpython/commit/9feae41c4f04ca27fd2c865807a5caeb50bf4fc4
commit: 9feae41c4f04ca27fd2c865807a5caeb50bf4fc4
branch: master
author: Victor Stinner <vstinner at python.org>
committer: vstinner <vstinner at python.org>
date: 2021-03-23T01:40:31+01:00
summary:
bpo-41718: libregrtest avoids importing datetime (GH-24985)
* libregrtest reimplements datetime.timedelta.__str__()
* support.testresult only imports datetime if USE_XML is true.
files:
M Lib/test/libregrtest/main.py
M Lib/test/support/testresult.py
diff --git a/Lib/test/libregrtest/main.py b/Lib/test/libregrtest/main.py
index 793c99a8f4ca3..1df927da403d6 100644
--- a/Lib/test/libregrtest/main.py
+++ b/Lib/test/libregrtest/main.py
@@ -1,4 +1,3 @@
-import datetime
import faulthandler
import locale
import os
@@ -150,9 +149,12 @@ def log(self, line=''):
# add the timestamp prefix: "0:01:05 "
test_time = time.monotonic() - self.start_time
- test_time = datetime.timedelta(seconds=int(test_time))
- line = f"{test_time} {line}"
+ mins, secs = divmod(int(test_time), 60)
+ hours, mins = divmod(mins, 60)
+ test_time = "%d:%02d:%02d" % (hours, mins, secs)
+
+ line = f"{test_time} {line}"
if empty:
line = line[:-1]
diff --git a/Lib/test/support/testresult.py b/Lib/test/support/testresult.py
index 6be3e5250ae58..670afbea2659d 100644
--- a/Lib/test/support/testresult.py
+++ b/Lib/test/support/testresult.py
@@ -9,8 +9,6 @@
import traceback
import unittest
-from datetime import datetime
-
class RegressionTestResult(unittest.TextTestResult):
separator1 = '=' * 70 + '\n'
separator2 = '-' * 70 + '\n'
@@ -21,6 +19,7 @@ def __init__(self, stream, descriptions, verbosity):
self.buffer = True
if self.USE_XML:
from xml.etree import ElementTree as ET
+ from datetime import datetime
self.__ET = ET
self.__suite = ET.Element('testsuite')
self.__suite.set('start', datetime.utcnow().isoformat(' '))
More information about the Python-checkins
mailing list