[Python-checkins] bpo-44828: Avoid leaving a zombie Save panel. (GH-29369)

ned-deily webhook-mailer at python.org
Tue Nov 2 17:03:03 EDT 2021


https://github.com/python/cpython/commit/6681a77c52df41636feb213d63ba27a759c7e5f4
commit: 6681a77c52df41636feb213d63ba27a759c7e5f4
branch: 3.10
author: Ned Deily <nad at python.org>
committer: ned-deily <nad at python.org>
date: 2021-11-02T17:02:58-04:00
summary:

bpo-44828: Avoid leaving a zombie Save panel. (GH-29369)

Patch by Marc Culler of the Tk project.

files:
M Mac/BuildScript/bpo-44828-filedialog-crash-monterey.patch

diff --git a/Mac/BuildScript/bpo-44828-filedialog-crash-monterey.patch b/Mac/BuildScript/bpo-44828-filedialog-crash-monterey.patch
index 1d06329fff3fb..059149250f8c8 100644
--- a/Mac/BuildScript/bpo-44828-filedialog-crash-monterey.patch
+++ b/Mac/BuildScript/bpo-44828-filedialog-crash-monterey.patch
@@ -18,7 +18,7 @@
  
      if (returnCode >= NSAlertFirstButtonReturn) {
  	Tcl_Obj *resultObj = Tcl_NewStringObj(alertButtonStrings[
-@@ -350,49 +350,41 @@
+@@ -350,49 +350,42 @@
      FilePanelCallbackInfo *callbackInfo)
  {
      NSInteger modalReturnCode;
@@ -85,6 +85,7 @@
 -	    [panel close];
 +			  returnCode:modalReturnCode
 +			 contextInfo:callbackInfo ];
++		[parent endSheet:panel];
  	}
 +    } else {
 +	modalReturnCode = [panel runModal];



More information about the Python-checkins mailing list