[Python-checkins] bpo-45401: Fix a resource warning in test_logging (GH-28864)

serhiy-storchaka webhook-mailer at python.org
Mon Oct 11 04:54:49 EDT 2021


https://github.com/python/cpython/commit/15188b115a2da815556053372c912a81a74be43b
commit: 15188b115a2da815556053372c912a81a74be43b
branch: main
author: Serhiy Storchaka <storchaka at gmail.com>
committer: serhiy-storchaka <storchaka at gmail.com>
date: 2021-10-11T11:54:44+03:00
summary:

bpo-45401: Fix a resource warning in test_logging (GH-28864)

files:
M Lib/test/test_logging.py

diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index b5885b985afd3..85b6e5f392111 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -5324,6 +5324,7 @@ def test_should_not_rollover(self):
         time.sleep(1.1)    # a little over a second ...
         r = logging.makeLogRecord({'msg': 'testing - device file'})
         self.assertFalse(fh.shouldRollover(r))
+        fh.close()
 
     # other test methods added below
     def test_rollover(self):



More information about the Python-checkins mailing list