[Python-checkins] bpo-45401: Fix a resource warning in test_logging (GH-28864) (GH-28872)
serhiy-storchaka
webhook-mailer at python.org
Tue Oct 12 03:19:14 EDT 2021
https://github.com/python/cpython/commit/47a50fe16f9f074daaaa3e6aa85e76502955ed40
commit: 47a50fe16f9f074daaaa3e6aa85e76502955ed40
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: serhiy-storchaka <storchaka at gmail.com>
date: 2021-10-12T10:19:09+03:00
summary:
bpo-45401: Fix a resource warning in test_logging (GH-28864) (GH-28872)
(cherry picked from commit 15188b115a2da815556053372c912a81a74be43b)
Co-authored-by: Serhiy Storchaka <storchaka at gmail.com>
files:
M Lib/test/test_logging.py
diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py
index 1a5f8b60f5ccb..93f6e5f85a0a3 100644
--- a/Lib/test/test_logging.py
+++ b/Lib/test/test_logging.py
@@ -5298,6 +5298,7 @@ def test_should_not_rollover(self):
time.sleep(1.1) # a little over a second ...
r = logging.makeLogRecord({'msg': 'testing - device file'})
self.assertFalse(fh.shouldRollover(r))
+ fh.close()
# other test methods added below
def test_rollover(self):
More information about the Python-checkins
mailing list