[Python-checkins] bpo-45182: Fix incorrect use of requires_zlib in test_bdist_rpm (GH-28305)

miss-islington webhook-mailer at python.org
Mon Sep 13 07:35:17 EDT 2021


https://github.com/python/cpython/commit/2f1d9bca144f3bbb4199111f4763ef05daea8526
commit: 2f1d9bca144f3bbb4199111f4763ef05daea8526
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2021-09-13T04:34:58-07:00
summary:

bpo-45182: Fix incorrect use of requires_zlib in test_bdist_rpm (GH-28305)


It is a decorator factory and should be always followed by "()".
(cherry picked from commit 9260e6739865c966c3ec6c5c289e0b96f848403e)

Co-authored-by: Serhiy Storchaka <storchaka at gmail.com>

files:
M Lib/distutils/tests/test_bdist_rpm.py

diff --git a/Lib/distutils/tests/test_bdist_rpm.py b/Lib/distutils/tests/test_bdist_rpm.py
index 6453a02b88f60..ba4382fb3a2fa 100644
--- a/Lib/distutils/tests/test_bdist_rpm.py
+++ b/Lib/distutils/tests/test_bdist_rpm.py
@@ -44,7 +44,7 @@ def tearDown(self):
     # spurious sdtout/stderr output under Mac OS X
     @unittest.skipUnless(sys.platform.startswith('linux'),
                          'spurious sdtout/stderr output under Mac OS X')
-    @requires_zlib
+    @requires_zlib()
     @unittest.skipIf(find_executable('rpm') is None,
                      'the rpm command is not found')
     @unittest.skipIf(find_executable('rpmbuild') is None,
@@ -87,7 +87,7 @@ def test_quiet(self):
     # spurious sdtout/stderr output under Mac OS X
     @unittest.skipUnless(sys.platform.startswith('linux'),
                          'spurious sdtout/stderr output under Mac OS X')
-    @requires_zlib
+    @requires_zlib()
     # http://bugs.python.org/issue1533164
     @unittest.skipIf(find_executable('rpm') is None,
                      'the rpm command is not found')



More information about the Python-checkins mailing list