[Python-checkins] bpo-45187: Fix dangling threads in test_socket.CreateServerFunctionalTest (GH-28422)

miss-islington webhook-mailer at python.org
Fri Sep 17 15:16:12 EDT 2021


https://github.com/python/cpython/commit/21711d53411e0da5976a9af591cd6ca97033f712
commit: 21711d53411e0da5976a9af591cd6ca97033f712
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2021-09-17T12:16:03-07:00
summary:

bpo-45187: Fix dangling threads in test_socket.CreateServerFunctionalTest (GH-28422)

(cherry picked from commit 51ebb7f4f5e9bdcf8279a1d91be9569706f6bead)

Co-authored-by: Serhiy Storchaka <storchaka at gmail.com>

files:
M Lib/test/test_socket.py

diff --git a/Lib/test/test_socket.py b/Lib/test/test_socket.py
index b6da4d09feece..5c15648b605c6 100755
--- a/Lib/test/test_socket.py
+++ b/Lib/test/test_socket.py
@@ -6492,13 +6492,6 @@ def test_dualstack_ipv6_family(self):
 class CreateServerFunctionalTest(unittest.TestCase):
     timeout = support.LOOPBACK_TIMEOUT
 
-    def setUp(self):
-        self.thread = None
-
-    def tearDown(self):
-        if self.thread is not None:
-            self.thread.join(self.timeout)
-
     def echo_server(self, sock):
         def run(sock):
             with sock:
@@ -6512,8 +6505,9 @@ def run(sock):
 
         event = threading.Event()
         sock.settimeout(self.timeout)
-        self.thread = threading.Thread(target=run, args=(sock, ))
-        self.thread.start()
+        thread = threading.Thread(target=run, args=(sock, ))
+        thread.start()
+        self.addCleanup(thread.join, self.timeout)
         event.set()
 
     def echo_client(self, addr, family):



More information about the Python-checkins mailing list