[Python-checkins] gh-100553: Improve accuracy of sqlite3.Row iter test (GH-100555)
miss-islington
webhook-mailer at python.org
Tue Dec 27 20:25:34 EST 2022
https://github.com/python/cpython/commit/fba8c7cf740433cc71280ea6dce6b44ee477b2d3
commit: fba8c7cf740433cc71280ea6dce6b44ee477b2d3
branch: 3.11
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2022-12-27T17:25:28-08:00
summary:
gh-100553: Improve accuracy of sqlite3.Row iter test (GH-100555)
(cherry picked from commit 3dc48dabd48864039951715816e07986a4828d80)
Co-authored-by: Nikita Sobolev <mail at sobolevn.me>
files:
M Lib/test/test_sqlite3/test_factory.py
diff --git a/Lib/test/test_sqlite3/test_factory.py b/Lib/test/test_sqlite3/test_factory.py
index cdaf12588a7f..2b70093bd9b6 100644
--- a/Lib/test/test_sqlite3/test_factory.py
+++ b/Lib/test/test_sqlite3/test_factory.py
@@ -179,8 +179,14 @@ def test_sqlite_row_iter(self):
"""Checks if the row object is iterable"""
self.con.row_factory = sqlite.Row
row = self.con.execute("select 1 as a, 2 as b").fetchone()
- for col in row:
- pass
+
+ # Is iterable in correct order and produces valid results:
+ items = [col for col in row]
+ self.assertEqual(items, [1, 2])
+
+ # Is iterable the second time:
+ items = [col for col in row]
+ self.assertEqual(items, [1, 2])
def test_sqlite_row_as_tuple(self):
"""Checks if the row object can be converted to a tuple"""
More information about the Python-checkins
mailing list