[Python-checkins] Remove skipped test in test for async mocks. (#100559)

cjw296 webhook-mailer at python.org
Wed Dec 28 05:56:18 EST 2022


https://github.com/python/cpython/commit/984894a9a25c0f8298565b0c0c2e1f41917e4f88
commit: 984894a9a25c0f8298565b0c0c2e1f41917e4f88
branch: main
author: Chris Withers <chris at withers.org>
committer: cjw296 <chris at withers.org>
date: 2022-12-28T10:55:50Z
summary:

Remove skipped test in test for async mocks. (#100559)

Remove skipped test.

See discussion on https://github.com/python/cpython/pull/25326.
Fix is apparently here, but no-one is confident to review and land: https://github.com/python/cpython/pull/25347.

files:
M Lib/test/test_unittest/testmock/testasync.py

diff --git a/Lib/test/test_unittest/testmock/testasync.py b/Lib/test/test_unittest/testmock/testasync.py
index 471162dc5050..5f12f9f95667 100644
--- a/Lib/test/test_unittest/testmock/testasync.py
+++ b/Lib/test/test_unittest/testmock/testasync.py
@@ -218,10 +218,6 @@ def test_create_autospec_instance(self):
         with self.assertRaises(RuntimeError):
             create_autospec(async_func, instance=True)
 
-    @unittest.skip('Broken test from https://bugs.python.org/issue37251')
-    def test_create_autospec_awaitable_class(self):
-        self.assertIsInstance(create_autospec(AwaitableClass), AsyncMock)
-
     def test_create_autospec(self):
         spec = create_autospec(async_func_args)
         awaitable = spec(1, 2, c=3)



More information about the Python-checkins mailing list