[Python-checkins] [3.11] Add an error message to the ABI-dump file check (#94129)

pablogsal webhook-mailer at python.org
Wed Jun 22 12:59:59 EDT 2022


https://github.com/python/cpython/commit/0dadb2249a8bafa7c5877daa08c9452f2248958a
commit: 0dadb2249a8bafa7c5877daa08c9452f2248958a
branch: 3.11
author: Pablo Galindo Salgado <Pablogsal at gmail.com>
committer: pablogsal <Pablogsal at gmail.com>
date: 2022-06-22T17:59:54+01:00
summary:

[3.11] Add an error message to the ABI-dump file check (#94129)

files:
M .github/workflows/build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 8de17345df6fd..70cafd8e07cdd 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -76,7 +76,16 @@ jobs:
           ./configure --enable-shared
           make -j4
       - name: Check for changes in the ABI
-        run: make check-abidump
+        run: |
+          make check-abidump
+          if [ $? -neq 0 ] ; then
+            echo "Generated ABI file is not up to date."
+            echo "Please, add the release manager of this branch as a reviewer of this PR."
+            echo ""
+            echo "To learn more about this check, please visit: https://devguide.python.org/setup/?highlight=abi#regenerate-the-abi-dump"
+            echo ""
+            exit 1
+          fi
 
   check_generated_files:
     name: 'Check if generated files are up to date'



More information about the Python-checkins mailing list