[Python-checkins] gh-94217: Skip import tests when _testcapi is a builtin (GH-94218)
miss-islington
webhook-mailer at python.org
Fri Jun 24 14:28:15 EDT 2022
https://github.com/python/cpython/commit/0a40025b803a8dc1d604538e317992827ab96625
commit: 0a40025b803a8dc1d604538e317992827ab96625
branch: main
author: Christian Heimes <christian at python.org>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2022-06-24T11:28:04-07:00
summary:
gh-94217: Skip import tests when _testcapi is a builtin (GH-94218)
files:
M Lib/test/test_importlib/extension/test_finder.py
M Lib/test/test_importlib/extension/test_loader.py
diff --git a/Lib/test/test_importlib/extension/test_finder.py b/Lib/test/test_importlib/extension/test_finder.py
index b6663a4484550..1d5b6e7a5de94 100644
--- a/Lib/test/test_importlib/extension/test_finder.py
+++ b/Lib/test/test_importlib/extension/test_finder.py
@@ -3,7 +3,7 @@
machinery = util.import_importlib('importlib.machinery')
import unittest
-import warnings
+import sys
class FinderTests(abc.FinderTests):
@@ -13,6 +13,10 @@ class FinderTests(abc.FinderTests):
def setUp(self):
if not self.machinery.EXTENSION_SUFFIXES:
raise unittest.SkipTest("Requires dynamic loading support.")
+ if util.EXTENSIONS.name in sys.builtin_module_names:
+ raise unittest.SkipTest(
+ f"{util.EXTENSIONS.name} is a builtin module"
+ )
def find_spec(self, fullname):
importer = self.machinery.FileFinder(util.EXTENSIONS.path,
diff --git a/Lib/test/test_importlib/extension/test_loader.py b/Lib/test/test_importlib/extension/test_loader.py
index 5080009bee32e..8570c6bc90cd0 100644
--- a/Lib/test/test_importlib/extension/test_loader.py
+++ b/Lib/test/test_importlib/extension/test_loader.py
@@ -20,6 +20,10 @@ class LoaderTests(abc.LoaderTests):
def setUp(self):
if not self.machinery.EXTENSION_SUFFIXES:
raise unittest.SkipTest("Requires dynamic loading support.")
+ if util.EXTENSIONS.name in sys.builtin_module_names:
+ raise unittest.SkipTest(
+ f"{util.EXTENSIONS.name} is a builtin module"
+ )
self.loader = self.machinery.ExtensionFileLoader(util.EXTENSIONS.name,
util.EXTENSIONS.file_path)
@@ -97,6 +101,10 @@ def setUp(self):
if not self.machinery.EXTENSION_SUFFIXES:
raise unittest.SkipTest("Requires dynamic loading support.")
self.name = '_testmultiphase'
+ if self.name in sys.builtin_module_names:
+ raise unittest.SkipTest(
+ f"{self.name} is a builtin module"
+ )
finder = self.machinery.FileFinder(None)
self.spec = importlib.util.find_spec(self.name)
assert self.spec
More information about the Python-checkins
mailing list