[Python-checkins] bpo-40280: Skip wakeup_fd pipe tests on Emscripten (GH-31909)

tiran webhook-mailer at python.org
Tue Mar 15 12:14:24 EDT 2022


https://github.com/python/cpython/commit/b43b9b49be7d42d2826106c719d1e51f0776be0a
commit: b43b9b49be7d42d2826106c719d1e51f0776be0a
branch: main
author: Christian Heimes <christian at python.org>
committer: tiran <christian at python.org>
date: 2022-03-15T17:14:15+01:00
summary:

bpo-40280: Skip wakeup_fd pipe tests on Emscripten (GH-31909)

files:
M Lib/test/test_signal.py

diff --git a/Lib/test/test_signal.py b/Lib/test/test_signal.py
index 09de608bb771f..37b46065e532c 100644
--- a/Lib/test/test_signal.py
+++ b/Lib/test/test_signal.py
@@ -205,6 +205,9 @@ def test_invalid_socket(self):
         self.assertRaises((ValueError, OSError),
                           signal.set_wakeup_fd, fd)
 
+    # Emscripten does not support fstat on pipes yet.
+    # https://github.com/emscripten-core/emscripten/issues/16414
+    @unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
     def test_set_wakeup_fd_result(self):
         r1, w1 = os.pipe()
         self.addCleanup(os.close, r1)
@@ -222,6 +225,7 @@ def test_set_wakeup_fd_result(self):
         self.assertEqual(signal.set_wakeup_fd(-1), w2)
         self.assertEqual(signal.set_wakeup_fd(-1), -1)
 
+    @unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
     def test_set_wakeup_fd_socket_result(self):
         sock1 = socket.socket()
         self.addCleanup(sock1.close)
@@ -241,6 +245,7 @@ def test_set_wakeup_fd_socket_result(self):
     # On Windows, files are always blocking and Windows does not provide a
     # function to test if a socket is in non-blocking mode.
     @unittest.skipIf(sys.platform == "win32", "tests specific to POSIX")
+    @unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
     def test_set_wakeup_fd_blocking(self):
         rfd, wfd = os.pipe()
         self.addCleanup(os.close, rfd)



More information about the Python-checkins mailing list