[Python-checkins] gh-90172: add test for functools.singledispatch on Union types with None type (#92174)
JelleZijlstra
webhook-mailer at python.org
Tue May 3 15:17:55 EDT 2022
https://github.com/python/cpython/commit/f03d3dd9afd5a2df8ffb6db80c0bb45f2d8909f5
commit: f03d3dd9afd5a2df8ffb6db80c0bb45f2d8909f5
branch: main
author: Thaddeus1499 <104600742+Thaddeus1499 at users.noreply.github.com>
committer: JelleZijlstra <jelle.zijlstra at gmail.com>
date: 2022-05-03T13:17:43-06:00
summary:
gh-90172: add test for functools.singledispatch on Union types with None type (#92174)
Signed-off-by: prwatson <prwatson at redhat.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra at gmail.com>
files:
M Lib/test/test_functools.py
diff --git a/Lib/test/test_functools.py b/Lib/test/test_functools.py
index e3c065615778f..382e7dbffddf9 100644
--- a/Lib/test/test_functools.py
+++ b/Lib/test/test_functools.py
@@ -2792,6 +2792,49 @@ def _(arg: int | float):
self.assertEqual(f(1), "types.UnionType")
self.assertEqual(f(1.0), "types.UnionType")
+ def test_union_conflict(self):
+ @functools.singledispatch
+ def f(arg):
+ return "default"
+
+ @f.register
+ def _(arg: typing.Union[str, bytes]):
+ return "typing.Union"
+
+ @f.register
+ def _(arg: int | str):
+ return "types.UnionType"
+
+ self.assertEqual(f([]), "default")
+ self.assertEqual(f(""), "types.UnionType") # last one wins
+ self.assertEqual(f(b""), "typing.Union")
+ self.assertEqual(f(1), "types.UnionType")
+
+ def test_union_None(self):
+ @functools.singledispatch
+ def typing_union(arg):
+ return "default"
+
+ @typing_union.register
+ def _(arg: typing.Union[str, None]):
+ return "typing.Union"
+
+ self.assertEqual(typing_union(1), "default")
+ self.assertEqual(typing_union(""), "typing.Union")
+ self.assertEqual(typing_union(None), "typing.Union")
+
+ @functools.singledispatch
+ def types_union(arg):
+ return "default"
+
+ @types_union.register
+ def _(arg: int | None):
+ return "types.UnionType"
+
+ self.assertEqual(types_union(""), "default")
+ self.assertEqual(types_union(1), "types.UnionType")
+ self.assertEqual(types_union(None), "types.UnionType")
+
def test_register_genericalias(self):
@functools.singledispatch
def f(arg):
More information about the Python-checkins
mailing list