[Python-checkins] bpo-42773: fix tests not being run on pushes (GH-24004) (GH-92341)

ned-deily webhook-mailer at python.org
Fri May 6 13:02:56 EDT 2022


https://github.com/python/cpython/commit/5adef3dd28854da4589be6937d3fcdc5c207276b
commit: 5adef3dd28854da4589be6937d3fcdc5c207276b
branch: 3.7
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: ned-deily <nad at python.org>
date: 2022-05-06T13:02:47-04:00
summary:

bpo-42773: fix tests not being run on pushes (GH-24004) (GH-92341)

There was a typo, we were checking if the "GITHUB_BASE_REF" string
literal was empty instead of the $GITHUB_BASE_REF value. When
$GITHUB_BASE_REF is empty, the action that triggered the run was not a
pull request, so we always run the full test suite.

Signed-off-by: Filipe Laíns <lains at riseup.net>
(cherry picked from commit 4ac923f2756f835f512339ee181348cc535ab07f)

files:
M .github/workflows/build.yml

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 530eba70b5ba2..f05da0938efd3 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -21,7 +21,7 @@ jobs:
       - name: Check for source changes
         id: check
         run: |
-          if [ -z "GITHUB_BASE_REF" ]; then
+          if [ -z "$GITHUB_BASE_REF" ]; then
             echo '::set-output name=run_tests::true'
           else
             git fetch origin $GITHUB_BASE_REF --depth=1



More information about the Python-checkins mailing list