[Python-checkins] gh-93172: Remove unnecessary "if"s in binascii_a2b_qp_impl() from Modules/binascii.c (GH-93181)

sweeneyde webhook-mailer at python.org
Wed May 25 11:38:59 EDT 2022


https://github.com/python/cpython/commit/32e3b790bc588c9ccbea810a4bea7a20bee43fb2
commit: 32e3b790bc588c9ccbea810a4bea7a20bee43fb2
branch: main
author: oda-gitso <105083118+oda-gitso at users.noreply.github.com>
committer: sweeneyde <36520290+sweeneyde at users.noreply.github.com>
date: 2022-05-25T11:38:47-04:00
summary:

gh-93172: Remove unnecessary "if"s in binascii_a2b_qp_impl() from Modules/binascii.c (GH-93181)

files:
M Modules/binascii.c

diff --git a/Modules/binascii.c b/Modules/binascii.c
index afe4988549171..ffc2c59413613 100644
--- a/Modules/binascii.c
+++ b/Modules/binascii.c
@@ -1024,10 +1024,7 @@ binascii_a2b_qp_impl(PyObject *module, Py_buffer *data, int header)
             out++;
         }
     }
-    if ((rv = PyBytes_FromStringAndSize((char *)odata, out)) == NULL) {
-        PyMem_Free(odata);
-        return NULL;
-    }
+    rv = PyBytes_FromStringAndSize((char *)odata, out);
     PyMem_Free(odata);
     return rv;
 }
@@ -1232,10 +1229,7 @@ binascii_b2a_qp_impl(PyObject *module, Py_buffer *data, int quotetabs,
             }
         }
     }
-    if ((rv = PyBytes_FromStringAndSize((char *)odata, out)) == NULL) {
-        PyMem_Free(odata);
-        return NULL;
-    }
+    rv = PyBytes_FromStringAndSize((char *)odata, out);
     PyMem_Free(odata);
     return rv;
 }



More information about the Python-checkins mailing list