[Python-checkins] gh-99300: Use Py_NewRef() in PC/ directory (#99479)

vstinner webhook-mailer at python.org
Mon Nov 14 12:49:56 EST 2022


https://github.com/python/cpython/commit/f5e326e2b6b3f008ed71ccf9e6c3e18a6618ea45
commit: f5e326e2b6b3f008ed71ccf9e6c3e18a6618ea45
branch: main
author: Victor Stinner <vstinner at python.org>
committer: vstinner <vstinner at python.org>
date: 2022-11-14T18:49:51+01:00
summary:

gh-99300: Use Py_NewRef() in PC/ directory (#99479)

Replace Py_INCREF() and Py_XINCREF() with Py_NewRef() and
Py_XNewRef() in test C files of the PC/ directory.

files:
M PC/_msi.c
M PC/winreg.c

diff --git a/PC/_msi.c b/PC/_msi.c
index 01f7fea7d2b6..b104e3c6ef54 100644
--- a/PC/_msi.c
+++ b/PC/_msi.c
@@ -701,8 +701,7 @@ _msi_SummaryInformation_GetProperty_impl(msiobj *self, int field)
             result = PyBytes_FromStringAndSize(sval, ssize);
             break;
         case VT_EMPTY:
-            Py_INCREF(Py_None);
-            result = Py_None;
+            result = Py_NewRef(Py_None);
             break;
         default:
             PyErr_Format(PyExc_NotImplementedError, "result of type %d", type);
diff --git a/PC/winreg.c b/PC/winreg.c
index 6ae0d8169cc5..df34e8cf5a77 100644
--- a/PC/winreg.c
+++ b/PC/winreg.c
@@ -308,8 +308,7 @@ static PyHKEYObject *
 winreg_HKEYType___enter___impl(PyHKEYObject *self)
 /*[clinic end generated code: output=52c34986dab28990 input=c40fab1f0690a8e2]*/
 {
-    Py_XINCREF(self);
-    return self;
+    return (PyHKEYObject*)Py_XNewRef(self);
 }
 
 
@@ -784,8 +783,7 @@ Reg2Py(BYTE *retDataBuf, DWORD retDataSize, DWORD typ)
            support it natively, we should handle the bits. */
         default:
             if (retDataSize == 0) {
-                Py_INCREF(Py_None);
-                obData = Py_None;
+                obData = Py_NewRef(Py_None);
             }
             else
                 obData = PyBytes_FromStringAndSize(



More information about the Python-checkins mailing list