[python-committers] Deny nonbreaking spaces in the precommit script?
Fredrik Lundh
fredrik at pythonware.com
Mon Nov 8 13:15:32 CET 2010
2010/11/8 Senthil Kumaran <orsenthil at gmail.com>:
> On Mon, Nov 08, 2010 at 11:55:39AM +0100, Łukasz Langa wrote:
>> Even if that commit hook prevents a single wrong commit a year, it's
>> worth it. As unpaid volunteers, we don't have time for hunting the
>> same mistakes twice.
>
> For common mistakes, there are commit hooks which prevent you from
> committing wrongly indented code or rst files. This helps couple of
> times a year, but having commit-hooks for every other mistake may not
> be a good idea.
Depends on how you phrase the tests, though -- the tests "does this
file only contain characters from the accepted character set" and
"does this file contain a non-breaking space" will both catch this
issue, but the former is more useful.
</F>
More information about the python-committers
mailing list