[python-committers] Commit privileges for Daniel Urban

[Nick Coghlan]

On Thu, May 17, 2012 at 2:31 AM, R. David Murray <rdmurray at bitdance.com> wrote:
> On Wed, 16 May 2012 10:59:57 +1000, Nick Coghlan <ncoghlan at gmail.com> wrote:
>> On Mon, May 14, 2012 at 9:23 PM, Nick Coghlan <ncoghlan at gmail.com> wrote:
>> > I'm proposing we grant commit privileges to Daniel Urban.
>> >
>> > He's provided patches for a number of fixes and feature requests for
>> > 3.2 and 3.3, including a particularly thorny one in the metaclass
>> > machinery. He's been very responsive on the tracker, and accommodating
>> > of the occasional dramatic shift in direction for a patch based on
>> > mailing list feedback (most recently, the operator.build_class in C ->
>> > types.build_class in Python change).
>>
>> Nobody else has an opinion on this? Positive *or* negative?
>
> Certainly not negative.  I haven't taken a look at his patch history,
> but certainly the traffic I saw about the metaclass stuff gave
> me a very positive impression.

In the absence of any -1 votes, I'll get Daniel to send his public key
through to the hgaccounts address. I'll still watch his commits and
remind him that getting patches reviewed on the tracker first is still
often the preferred approach, even for committers.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia