[python-committers] review links

Gregory P. Smith greg at krypto.org
Mon Feb 3 20:47:48 CET 2014


actually if your patch contains

"diff -r f4377699fd47 Lib/test/test_zipimport.py"

lines prior to the --- line as hg diff can emit, it'll do the right thing
and show the review against the version of the file listed (or at least
against it's branch head? that's an example taken from 3.3 for a patch that
most definitely does not apply cleanly to default||3.4)

-gps



On Mon, Feb 3, 2014 at 9:20 AM, Antoine Pitrou <solipsis at pitrou.net> wrote:

> On lun., 2014-02-03 at 09:16 -0800, Guido van Rossum wrote:
> > IIRC the review link only appears if the patch applies cleanly.
>
> And only if it applies cleanly on the default branch, IIRC :-)
>
> Regards
>
> Antoine.
>
>
>
> _______________________________________________
> python-committers mailing list
> python-committers at python.org
> https://mail.python.org/mailman/listinfo/python-committers
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-committers/attachments/20140203/43318965/attachment-0001.html>


More information about the python-committers mailing list