[python-committers] [Core-mentorship] Regarding reviewing test cases written for tabnanny module

[Mariatta Wijaya]

So there is already a PR in the devguide advising contributors to keep
their commit history intact, see https://github.com/python/devguide/pull/162
Assuming people do read the devguide, then let's hope that we won't lose
the commit history going forward.

There is also already a section in the devguide instructing core devs to
clean up commit message, see http://cpython-devguide.re
adthedocs.io/gitbootcamp.html#accepting-and-merging-a-pull-request If this
is not clear enough, please propose a PR or file an issue.


Back to the original issue with reviewing the PR https://github.com/python/
cpython/pull/851

Other than not being able to review the diff, is there any other problem?
Can the PR be reviewed as is?

Martin, you said: "I’m not really set up to properly review and push stuff
with the new Git Hub setup,"
Are you wanting to make edits to the PR yourself?
If so, maybe you can try these instructions: http://cpython-devguide.
readthedocs.io/gitbootcamp.html#editing-a-pull-request-prior-to-merging



Mariatta Wijaya

On Tue, Apr 11, 2017 at 11:30 AM, Terry Reedy <tjreedy at udel.edu> wrote:

> On 4/11/2017 1:21 PM, Donald Stufft wrote:
>
>>
>> On Apr 11, 2017, at 12:25 PM, Terry Reedy <tjreedy at udel.edu
>>> <mailto:tjreedy at udel.edu>> wrote:
>>>
>>
> I was under the impression that the green [commit] button would do the
>>> squashing.   Or at least that it could.
>>>
>>>
>> Yes it can, and IIRC for CPython we have it set so it _only_ does that.
>> Although the commit message may be ugly if you don’t adjust it in the
>> text editor that pops up when GitHub asks you to confirm the merge since
>> it by default just concats all of the commit messages into a list so you
>> might get a commit message like:
>>
>> * implement feature
>>
>> * fix thing
>>
>> * ugh
>>
>> * address review
>>
>> Instead of a nice clean one. That’s going to be up to the person hitting
>> the merge button to edit the commit message to be clean though.
>>
>
> I think committers should always be responsible for the commit message.
> This will usually mean editing submissions from non-committers.  Since
> message is truncated to first line in some displays, the latter should
> summarize main point of commit.
>
>
> _______________________________________________
> python-committers mailing list
> python-committers at python.org
> https://mail.python.org/mailman/listinfo/python-committers
> Code of Conduct: https://www.python.org/psf/codeofconduct/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-committers/attachments/20170411/9334aa55/attachment-0001.html>