[python-committers] My cavalier and aggressive manner, API change and bugs introduced for basically zero benefit

Victor Stinner victor.stinner at gmail.com
Fri Jan 27 10:04:16 EST 2017


2017-01-21 20:51 GMT+01:00 Brett Cannon <brett at python.org>:
> What I'm picking up from this is (as a gross oversimplification):
>
> * Victor _wants_ code reviews
> * Raymond thinks we _need_ code reviews

For a concrete example, I wrote a patch for a major regression in the
datetime module at 2017-01-04:
http://bugs.python.org/issue29100

I'm waiting for a review. To be honest, I almost forgot this issue
since I didn't get any feedback. I didn't get any review. In the
meanwhile, a duplicate was opened:
http://bugs.python.org/issue29346

Usually, when this case occurs, I push my patch without review. But
since some developers wrote that the want to review, please take a
look at timestamp_limits.patch of http://bugs.python.org/issue29100 !

"timestamp_limits.patch is waiting for your review! This issue is a
major regression of Python 3.6. I'm going to push the patch in one
week if I don't get any review."

Victor


More information about the python-committers mailing list