[python-committers] Should I merge a PR that I approved if it was written by a different core developer?

[Nick Coghlan]

On 21 September 2017 at 07:27, Victor Stinner <victor.stinner at gmail.com> wrote:
> Hi,
>
> Before the GitHub era, in the old "Mercurial era", the unwritten rule
> was to not merge a patch written by a developer who has the commit
> bit, to not "steal" his/her work. The old workflow (patches attached
> to the bug tracker) didn't allow to easily keep the author. You had to
> find the author email and full name and specify it manually.

I'll typically still just leave an "Approve" review rather than
merging directly, unless it's a PR for an issue I filed, or I'm
working on a separate change that would end up conflicting with their
PR if I left theirs open.

That way if they think of an alternative approach that they'd prefer
to use, they can still just amend their existing PR and ask for an
additional review, rather than having to submit a new PR.

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia