[python-committers] Should I merge a PR that I approved if it was written by a different core developer?

Victor Stinner victor.stinner at gmail.com
Thu Sep 21 16:58:19 EDT 2017


Ok, no problem, let's say that a core dev should not merge a PR written by
another core dev.

In fact, I was already following this rule. I hesitated many times to click
on Merge, but I wanted first to open a discussion. Here we are :-)


Obvious, the good practice is to put as many approval as possible, by
different developers :-)

Victor
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-committers/attachments/20170921/f00ed5be/attachment.html>


More information about the python-committers mailing list