[python-committers] Merge with spurious CI failures?

[Eric V. Smith]

D’oh! Good point!

Eric

> On May 8, 2019, at 11:52 AM, Alex Gaynor <alex.gaynor at gmail.com> wrote:
> 
> Tests for that PR would presumably be green :-)
> 
> Alex
> 
>> On Wed, May 8, 2019 at 11:51 AM Eric V. Smith <eric at trueblade.com> wrote:
>> Surely there must be some way around it. After all, how would you merge a PR to fix this test?
>> 
>> --
>> Eric V. Smith
>> True Blade Systems, Inc
>> (301) 859-4544
>> 
>>> On May 8, 2019, at 11:49 AM, Mariatta <mariatta at python.org> wrote:
>>> 
>>> If you can't merge from GitHub UI then you won't be able to do it from GitHub command line (it respects the same branch protection policy)
>>> 
>>> I don't think we should merge if tests are still failing. Perhaps the test should be adjusted to handle this spurious errors? Can it be marked as "allowed failure" or something like that?
>>> 
>>> 
>>>> On Wed, May 8, 2019, 8:32 AM Antoine Pitrou <antoine at python.org> wrote:
>>>> 
>>>> Hello,
>>>> 
>>>> There are spurious CI failures (SSL certificate issue in test_httplib).
>>>> Therefore the "Squash and merge" button is greyed out.
>>>> 
>>>> How should I merge? Using the command-line instructions from Github?
>>>> 
>>>> Regards
>>>> 
>>>> Antoine.
>>>> _______________________________________________
>>>> python-committers mailing list
>>>> python-committers at python.org
>>>> https://mail.python.org/mailman/listinfo/python-committers
>>>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>>> _______________________________________________
>>> python-committers mailing list
>>> python-committers at python.org
>>> https://mail.python.org/mailman/listinfo/python-committers
>>> Code of Conduct: https://www.python.org/psf/codeofconduct/
>> _______________________________________________
>> python-committers mailing list
>> python-committers at python.org
>> https://mail.python.org/mailman/listinfo/python-committers
>> Code of Conduct: https://www.python.org/psf/codeofconduct/
> 
> 
> -- 
> All that is necessary for evil to succeed is for good people to do nothing.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/python-committers/attachments/20190508/500f2981/attachment.html>