[Python-Dev] 's' vs 'z' format (was: CVS: python/dist/src/Modules readline.c,2.18,2.19)

[Skip Montanaro]

    Greg> On Thu, Jul 06, 2000 at 11:55:14AM -0700, Skip Montanaro wrote:
    >> ...
    >> + /* Exported function to load a readline history file */
    >> + 
    >> + static PyObject *
    >> + read_history_file(self, args)
    >> + 	PyObject *self;
    >> + 	PyObject *args;
    >> + {
    >> + 	char *s = NULL;
    >> + 	if (!PyArg_ParseTuple(args, "|z:read_history_file", &s))

    Greg> This allows somebody to pass read_history_file(None). That doesn't
    Greg> feel right. I'd suggest using the 's' format code.

Thanks, I'll fix it tomorrow.  I basically cloned read_init_file's code.
That probably needs a tweak as well.

Skip