[Python-Dev] Re: CVS: python/dist/src/Lib locale.py,1.7,1.8

Greg Stein gstein@lyra.org
Mon, 10 Jul 2000 02:09:31 -0700

This checkin was *very* hard to review. In fact, I just gave up.

The problem is that you did functional changes *AND* white space changes. A
bunch of lines appear changed, but they're just whitespace change. The
*real* changes are hidden in there somewhere.

Can I request (from everyone) to do white space changes *only*, or to do
functional changes *only*. It will make it a lot easier on the people who
are reviewing the checkins.


On Sun, Jul 09, 2000 at 10:13:00AM -0700, Fredrik Lundh wrote:
> Update of /cvsroot/python/python/dist/src/Lib
> In directory slayer.i.sourceforge.net:/tmp/cvs-serv2501/Lib
> Modified Files:
> 	locale.py 
> Log Message:
> - merged setlocale and set_locale.  the internal setlocale
>   function is overridden by a python version which accepts
>   *either* a string (old behaviour) or a locale tuple.
> - renamed a few methods (for consistency):
>         get_locale => getlocale
>         get_default_locale => getdefaultlocale
>         set_to_default => resetlocale (!)
> - the _locale implementation module can now implement
>   an optional _getdefaultlocale function.  if that function
>   isn't available, a POSIX-based approach is used (checking
>   LANG and other environment variables, as usual).

Greg Stein, http://www.lyra.org/