[Python-Dev] ANSIfication again ;)

Peter Schneider-Kamp peter@schneider-kamp.de
Thu, 20 Jul 2000 23:49:02 +0000

Thomas Wouters wrote:
> And I fixed almost all of the instances of K&R C syntax. However, I found a
> lot of instances of the 2nd type: empty argument list. However, as far as I
> remember, ANSI C states that should be written as '(void)'. Is that a
> non-issue, and should I not bother fixing those ? (Most of the files in
> Modules/ has one or more instances of those.)

Yes, I think that's right. I just looked at them and thought: Oh, no
parameters - no work ;-)

But then even "gcc -pedantic -ansi" doesn't care about this.
Take that as a +0.

> I also found a number of files which were already converted to ANSI syntax,
> but with one function leftover. Should I bother uploading a patch for those,
> or can I just commit them ? They're only a few lines per file, after all.

I'd guess that if you feel that it's right and there is no functional
involved no one will object.

not-feeling-competent-enough-for-a-straight-"just-do-it"-ly y'rs
Peter Schneider-Kamp          ++47-7388-7331
Herman Krags veg 51-11        mailto:peter@schneider-kamp.de
N-7050 Trondheim              http://schneider-kamp.de