[Python-Dev] Warnings in mmapmodule

[Trent Mick]

On Wed, Jun 21, 2000 at 01:22:37AM -0400, Tim Peters wrote:
> [posted & mailed]
> 
> [Tim]
> > I get these warnings in Modules/mmapmodule.c, all about signed/unsigned
> > mismatches:
> 
> [Mark Hammond]
> > Me too :-)
> >
> > I nearly [fixed them], but then couldnt find the time to chase up how
> > Unix declared the relevant items - I didnt want to assume they were
> > identical to Windows.
> 
> They all involve mixing ints with mmap_object.size in comparisons, which
> latter is declared size_t and so will resolve to *some* unsigned integral
> type on all platforms.  The proper fix is to get rid of the ints before
> making these tests -- ask Trent, he should be able to do this in his sleep
> now <wink>.
> 

I wish I could do it in my sleep, then I would be much more well rested. Yes
I will clean these up. I was going to look at mmap a little anyway as
test_mmap currently fails on Win32 (probably as a resul of my mmpa patch).

Trent


-- 
Trent Mick
trentm@activestate.com