[Python-Dev] Release candidate followed by feature freeze?

Fredrik Lundh Fredrik Lundh" <effbot@telia.com
Thu, 5 Oct 2000 16:51:25 +0200


> > To check if Rob's program works better without it, you can comment
> > out the "_flatten = _tkinter._flatten" line in Tkinter.py (it's line 70 or
> > so, iirc).
> 
> That fixes the crash as well.

in other words, _PyTuple_Resize needs some work...

(or does _flatten do something wrong?  it starts by creating
a tuple, and if it needs more space, it doubles the size one or
more times, and ends by calling Resize again to set the final
size...)

:::

btw, the start of Resize looks a bit strange: should that
DECREF really be there?  should least be an XDECREF, or
am I missing something?

 if (v == NULL || !PyTuple_Check(v) || v->ob_refcnt != 1) {
  *pv = 0;
  Py_DECREF(v); /* really? what if v is NULL? */
  PyErr_BadInternalCall();
  return -1;
 }

</F>