[Python-Dev] 2.2a1 patch from PyChecker
Guido van Rossum
Mon, 13 Aug 2001 11:46:31 -0400
Going through your patches, I notice a few areas where I disagree.
- You want to change all occurrences of "except <exc>, <var>:" where
<var> is unused. I don't -- often it's more regular to leave <var>
- You want to change all occurrences of "func(name=value)" where name
is an argument without a default. I disagree that a default is
necessary for an argument to be acceptable as a keyword argument.
- You want to change "for i in <expr>" into "for _ in <expr>" when i
is unused. I disagree (we've been through this).
Also, I can't figure out why you want to delete the setlocale() method
from the locale.py module.
Apart from these, I'm applying many of these, and Andrew has already
applied many more. So thanks again!
One thing. Next time please use a recent CVS. Martin had already
fixed many of the missing imports. (If others agree, we could give
you checkin permission so you could check in non-controversial fixes
--Guido van Rossum (home page: http://www.python.org/~guido/)