[Python-Dev] Re: [Python-checkins] CVS: python/dist/src/Objects stringobject.c,2.124,2.125

Barry A. Warsaw barry@zope.com
Sun, 26 Aug 2001 23:08:33 -0400

>>>>> "GS" == Greg Stein <gstein@lyra.org> writes:

    GS> For safety/propriety, you should call va_end() on the vargs
    GS> variable.

Good catch!  I meant to add that after noticing the original code
didn't contain it, and after double checking with the Linux manpage
for va_start.  I touched so much other code I forgot to go back and
add that call.  Will do so now...

    GS> You could use: s - PyString_AS_STRING(string)

Good call.  The original code had the former, but you're right that
this is better.