[Python-Dev] Re: [Python-checkins] CVS: python/dist/src/Modules socketmodule.c,1.135,1.136

Thomas Wouters thomas@xs4all.net
Wed, 7 Feb 2001 00:09:55 +0100


On Tue, Feb 06, 2001 at 02:58:07PM -0800, A.M. Kuchling wrote:
> Update of /cvsroot/python/python/dist/src/Modules
> In directory usw-pr-cvs1:/tmp/cvs-serv21837

> Modified Files:
> 	socketmodule.c 
> Log Message:
> Patch #103636: Allow writing strings containing null bytes to an SSL socket

> Index: socketmodule.c
> ===================================================================
> RCS file: /cvsroot/python/python/dist/src/Modules/socketmodule.c,v
> retrieving revision 1.135
> retrieving revision 1.136
> diff -C2 -r1.135 -r1.136
> *** socketmodule.c	2001/02/02 19:55:17	1.135
> --- socketmodule.c	2001/02/06 22:58:05	1.136
> ***************
> *** 2219,2223 ****
>   	size_t len = 0;
>     
> ! 	if (!PyArg_ParseTuple(args, "s|i:write", &data, &len))
>   		return NULL;
>     
> --- 2219,2223 ----
>   	size_t len = 0;
>     
> ! 	if (!PyArg_ParseTuple(args, "s#|i:write", &data, &len))
>   		return NULL;

This doesn't seem right. The new function needs another 'length' argument
(an int), and the smallest of the two should be used.

-- 
Thomas Wouters <thomas@xs4all.net>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!