[Python-Dev] Re: [Python-checkins] CVS: python/dist/src/Objects fileobject.c,2.102,2.103

[Greg Stein]

On Mon, Jan 08, 2001 at 06:00:13PM -0800, Guido van Rossum wrote:
>...
> Modified Files:
> 	fileobject.c 
> Log Message:
> Tsk, tsk, tsk.  Treat FreeBSD the same as the other BSDs when defining
> a fallback for TELL64.  Fixes SF Bug #128119.
>...
> *** fileobject.c	2001/01/08 04:02:07	2.102
> --- fileobject.c	2001/01/09 02:00:11	2.103
> ***************
> *** 59,63 ****
>   #if defined(MS_WIN64)
>   #define TELL64 _telli64
> ! #elif defined(__NetBSD__) || defined(__OpenBSD__) || defined(_HAVE_BSDI) || defined(__APPLE__)
>   /* NOTE: this is only used on older
>      NetBSD prior to f*o() funcions */
> --- 59,63 ----
>   #if defined(MS_WIN64)
>   #define TELL64 _telli64
> ! #elif defined(__NetBSD__) || defined(__OpenBSD__) || defined(__FreeBSD__) || defined(_HAVE_BSDI) || defined(__APPLE__)
>   /* NOTE: this is only used on older
>      NetBSD prior to f*o() funcions */

All of those #ifdefs could be tossed and it would be more robust (long term)
if an autoconf macro were used to specify when TELL64 should be defined.

[ I've looked thru fileobject.c and am a bit confused: the conditions for
  defining TELL64 do not match the conditions for *using* it. that would
  seem to imply a semantic error somewhere and/or a potential gotcha when
  they get skewed (like I assume what happened to FreeBSD). simplifying with
  an autoconf macro may help to rationalize it. ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/