[Python-Dev] Re: [Python-checkins] CVS: python/dist/src/Lib httplib.py,1.26,1.27

[Greg Stein]

On Sat, Jan 13, 2001 at 08:55:35AM -0800, Guido van Rossum wrote:
> Update of /cvsroot/python/python/dist/src/Lib
> In directory usw-pr-cvs1:/tmp/cvs-serv14586
> 
> Modified Files:
> 	httplib.py 
> Log Message:
> SF Patch #103225 by Ping: httplib: smallest Python patch ever
>...

Not so small:

>...
> *** 333,337 ****
>               i = host.find(':')
>               if i >= 0:
> !                 port = int(host[i+1:])
>                   host = host[:i]
>               else:
> --- 333,340 ----
>               i = host.find(':')
>               if i >= 0:
> !                 try:
> !                     port = int(host[i+1:])
> !                 except ValueError, msg:
> !                     raise socket.error, str(msg)
>                   host = host[:i]
>               else:


Did you intend to commit this?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/