[Python-Dev] Re: test_support.py

[M.-A. Lemburg]

Guido van Rossum wrote:
> 
> >       if not condition:
> > !         raise AssertionError(reason)
> 
> Wouldn't it be better if this raised TestFailed rather than
> AssertionError?  Or is there code that catches the AssertionError?
> 
> [...grep...]
> 
> Yes, there's code that catches AssertionError:
> 
> (1) in Marc-Andre's own test_unicode.py;
> 
> (2) in test_re, which catches AssertionError and raises TestFailed
>     instead.
> 
> Proposal:
> 
> (1) change verify() to raise TestFailed;
> 
> (2) change test_unicode.py to catch TestFailed instead.

+1

Why not simply make TestFailed a subclass of AssertionError ?
Then we wouldn't have to fear about breaking test code...

-- 
Marc-Andre Lemburg
______________________________________________________________________
Company:                                        http://www.egenix.com/
Consulting:                                    http://www.lemburg.com/
Python Pages:                           http://www.lemburg.com/python/