[Python-Dev] 2.1.2: patching Modules/

[Martin von Loewis]

[\n\ -> \n" conversion]
> Did these actually fix anything?

Looking at the check-in message to mathmodule.c 2.61, we see

author: tim_one;
# Mechanical fiddling to make this easier to work with in my editor.

So I guess the answer is: "yes, it makes Tim's editor happy" :-) Apart
from that, it apparently didn't fix any further problems.

> many files: config.h -> pyconfig.h: Don't see a point - if it's broken in 
> 2.1.1, it'll still be broken in 2.1.2. 

Indeed. Furthermore, applications (including distutils) may rely on
knowing the name of the config.h; those would break with the change.

> Modules/zlibmodule.c: allow threads in zlib, misc other fixes - diff
> is nearly the entire file. The fix for patch #403753 would be good,
> but is an incompatibility. Hm.

I don't think this qualifies as a "bug fix". It fixes a problem, yes,
but applications have to be changed to make use of the feature.

> gcmodule: the lock to stop multiple calls to collect() - pretty sure
> I've got a working patch for this, but it's hard to test.

Why can't you use the patch as-is? It would apply without problems, if
generation0 hadn't been renamed to _PyGC_generation0.

> _curses*

If "didn't build before, does now" also is a candidate for inclusion,
I think you could more or less use _cursesmodule.c as-is. If you only
want fixes for systems on which it already worked, it will be more
difficult.

Regards,
Martin