[Python-Dev] CRLF in email.Generator

[Gustavo Niemeyer]

--5vNYLRcllDrimb99
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Barry!!

First, I'd like to thank you for implementing the email package.
It seems very complete and will be useful for sure.

I've been looking at the Generator module. It seems to be writing
the message with:

print >> self._fp, "text"

This should probably be replaced by:

self._fp.write("text"+"\r\n")

Print's end of line will depend on the system where python is being
run. If you run it in Linux, it will output just a "\n". This breaks
RFC2822:

"""
Messages are divided into lines of characters.  A line is a series of
characters that is delimited with the two characters carriage-return
and line-feed; that is, the carriage return (CR) character (ASCII
value 13) followed immediately by the line feed (LF) character (ASCII
value 10).  (The carriage-return/line-feed pair is usually written in
this document as "CRLF".)
"""

As a side note, I'd like to suggest the inclusion of some kind of
"raw_input". There are cases where you want to see the raw message
(or just part of it), instead of regenerating it. This happens, for
example, when you want to check a signed multipart message.

Thank you very much!

--=20
Gustavo Niemeyer

[ 2AAC 7928 0FBF 0299 5EB5  60E2 2253 B29A 6664 3A0C ]

--5vNYLRcllDrimb99
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE79R7CIlOymmZkOgwRAl4rAKCXP/D8S2ZnJtdaKCSMymsrZMQE/ACeKIWW
Ut7yeOJlKyaEAYuO8I/OAJQ=
=t+I9
-----END PGP SIGNATURE-----

--5vNYLRcllDrimb99--