[Python-Dev] Fixing compiler warnings (bug #445960)

[Greg Ward]

What's the general feeling/policy on fixing very minor problems that cause 
legitimate compiler warnings with some compilers?  ISTR that Tim is adamant 
about keeping Python warning-free on Windows with MSVC, but what about, say, 
the compiler that ships with IRIX 6.5?  It's not a widely-used platform, but 
the compiler does catch some genuine, albeit small, problems -- mostly of the 
"variable set but never used" variety.

It looks like most fixes are along the lines of changing this:

static int
init_builtin(char *name)
{
	struct _inittab *p;
	PyObject *mod;

	if ((mod = _PyImport_FindExtension(name, name)) != NULL)
		return 1;

to this:

static int
init_builtin(char *name)
{
	struct _inittab *p;