[Python-Dev] Goals for patch selection for 2.1.2

Jeremy Hylton jeremy@zope.com
Mon, 22 Oct 2001 20:52:09 -0400 (EDT)


>>>>> "AB" == Anthony Baxter <anthony@interlink.com.au> writes:

  AB>   Things that shouldn't be considered:
  [...]
  AB>     Fixes that "remove a nasty workaround"

  AB>   In general, I'd like the starting point for any patch to be
  AB>   considered as "guilty until proven necessary".

Do you have an opinion on the recent change to traceback.c (make it
collectable)?  I think it's a good candidate for 2.1.2 even though it
doesn't meet the criteria above :-).

It removes the nasty workaround that you *never* exit a function with
a local variable that points to a traceback that references the
function.  There's a bit of C code (most of it probably extending the
type structure for tracebacks), but it's simple stuff, thoroughly
tested by the current test suite, and it's a *nasty* problem in
practice. 

Two other things I thought of on this thread:

    We got out of the habit of marking changes in 2.2 as potential
    bug fixes, because we didn't expect to have a 2.1.2 release.  I
    think we should continue marking checkins this way indefinitely.
    We may not have a 2.1.3 and a 2.2.2, but it's pretty easy to mark
    the checkin just in case we do make such a release.

    I'd like to update the compiler package in Tools/compiler, because
    I've fixed a number of nasty bugs, e.g. computing a stack size
    that is too small for a function.  But I don't know if I'll have
    time.  Once you've got a schedule, I'll let you know if I can
    manage it.

Jeremy