[Python-Dev] New test failure: test_imaplib.py

[Tino Lange]

This is a cryptographically signed message in MIME format.

--------------msB943C623BE2B0E4E3135F8D9
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi!

Indeed, IMAP4_SSL_PORT is missing in the checked in version.
But it was in my patch, that I've submitted yesterday?!
Maybe Piers did the patch just by hand, not by "patch"?

It's mainly the missing IMAP4_SSL_PORT and one "," too much in the
docstring of IMAP4_SSL_PORT.
Increasing of version numer is OK, of course - this I forgot :-)

Best regards

Tino

-----------------
-----------------

These are the differences between my patch and the CVS version at the
moment:

tino@tinux:~/> diff -c imaplib_tl.py imaplib_cvs.py
*** imaplib_tl.py       Fri Mar  8 09:04:54 2002
--- imaplib_cvs.py      Fri Mar  8 09:03:50 2002
***************
*** 15,23 ****
  # Authentication code contributed by Donn Cave <donn@u.washington.edu>
June 1998.
  # String method conversion by ESR, February 2001.
  # GET/SETACL contributed by Anthony Baxter <anthony@interlink.com.au>
April 2001.
! # IMAP4_SSL contributed by Tino Lange <tino.lange@isg.de> March 2002

! __version__ = "2.50"

  import binascii, re, socket, time, random, sys

--- 15,23 ----
  # Authentication code contributed by Donn Cave <donn@u.washington.edu>
June 1998.
  # String method conversion by ESR, February 2001.
  # GET/SETACL contributed by Anthony Baxter <anthony@interlink.com.au>
April 2001.
! # IMAP4_SSL contributed by Tino Lange <Tino.Lange@isg.de> March 2002.

! __version__ = "2.51"

  import binascii, re, socket, time, random, sys

***************
*** 29,35 ****
  CRLF = '\r\n'
  Debug = 0
  IMAP4_PORT = 143
- IMAP4_SSL_PORT = 993
  AllowedVersions = ('IMAP4REV1', 'IMAP4')        # Most recent first

  #       Commands
--- 29,34 ----
***************
*** 983,993 ****
                  n -= 1


  class IMAP4_SSL(IMAP4):

      """IMAP4 client class over SSL connection

!     Instantiate with: IMAP4_SSL([host[, port[, keyfile[, certfile]]]])

              host - host's name (default: localhost);
              port - port number (default: standard IMAP4 SSL port).
--- 982,993 ----
                  n -= 1


+
  class IMAP4_SSL(IMAP4):

      """IMAP4 client class over SSL connection

!     Instantiate with: IMAP4_SSL([, host[, port[, keyfile[,
certfile]]]])

              host - host's name (default: localhost);
              port - port number (default: standard IMAP4 SSL port).
***************
*** 1052,1057 ****
--- 1052,1058 ----
          ssl = <instance>.socket.ssl()
          """
          return self.sslobj
+


  class _Authenticator:
tino@tinux:~/ >
--------------msB943C623BE2B0E4E3135F8D9
Content-Type: application/x-pkcs7-signature; name="smime.p7s"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="smime.p7s"
Content-Description: S/MIME Cryptographic Signature

MIIGeQYJKoZIhvcNAQcCoIIGajCCBmYCAQExCzAJBgUrDgMCGgUAMAsGCSqGSIb3DQEHAaCC
BCEwggQdMIIDhqADAgECAgIC0DANBgkqhkiG9w0BAQQFADCBvjELMAkGA1UEBhMCREUxDzAN
BgNVBAgTBkhlc3NlbjEaMBgGA1UEBxMRRnJhbmtmdXJ0IGFtIE1haW4xITAfBgNVBAoTGElu
bm92YXRpdmUgU29mdHdhcmUgR21iSDEfMB0GA1UECxMWTmV0d29yayBBZG1pbmlzdHJhdGlv
bjEiMCAGA1UEAxMZSVNHIENlcnRpZmljYXRlIEF1dGhvcml0eTEaMBgGCSqGSIb3DQEJARYL
aW5mb0Bpc2cuZGUwHhcNMDEwNzAyMTQwODQyWhcNMDYxMjIzMTQwODQyWjCBmjELMAkGA1UE
BhMCREUxEjAQBgNVBAgTCUZyYW5rZnVydDESMBAGA1UEBxMJRnJhbmtmdXJ0MRwwGgYDVQQK
ExNJbm5vdmF0aXZlIFNvZnR3YXJlMQ4wDAYDVQQLEwVJUy1ERTETMBEGA1UEAxMKVGlubyBM
YW5nZTEgMB4GCSqGSIb3DQEJARYRdGluby5sYW5nZUBpc2cuZGUwgZ8wDQYJKoZIhvcNAQEB
BQADgY0AMIGJAoGBALvDjXu01p+UWa3VQRSw8XJeV9zVyQfIN3lBr3esKdB0TawZM2+Fm1sf
puDx5XjOnJ5TYIWTBFP4OnbG8T3tzmmcTD7m9N9Ks/NxTBYVwJeNN7lSCBiQ36VhFFNdMINM
zLjDwQQInFCdj3VqyswXP/rxvQ331o4k9F2tXyhaEDoNAgMBAAGjggFKMIIBRjAJBgNVHRME
AjAAMCwGCWCGSAGG+EIBDQQfFh1PcGVuU1NMIEdlbmVyYXRlZCBDZXJ0aWZpY2F0ZTAdBgNV
HQ4EFgQUbgd332z6d1qrT9MECmHKFaO8wFUwgesGA1UdIwSB4zCB4IAUnLMIpiBUdLGe0Y2Q
oriseGaX0bqhgcSkgcEwgb4xCzAJBgNVBAYTAkRFMQ8wDQYDVQQIEwZIZXNzZW4xGjAYBgNV
BAcTEUZyYW5rZnVydCBhbSBNYWluMSEwHwYDVQQKExhJbm5vdmF0aXZlIFNvZnR3YXJlIEdt
YkgxHzAdBgNVBAsTFk5ldHdvcmsgQWRtaW5pc3RyYXRpb24xIjAgBgNVBAMTGUlTRyBDZXJ0
aWZpY2F0ZSBBdXRob3JpdHkxGjAYBgkqhkiG9w0BCQEWC2luZm9AaXNnLmRlggEAMA0GCSqG
SIb3DQEBBAUAA4GBAH7LGTV3LYJF7UmELcuJa4Sf1SRPpD3Swziqc7sLE1c3wPxtsyzxEW79
I4kPsEIvjii4naImEF5Uj/xSpFPEIy9ZihB8Fi4yc06QSrwhhYK0sND7bp15oB9XNDIvQGuX
0b0xj4icIrDPXOlfhRrODvVtPxMYwt65CLq/umTqYh98MYICIDCCAhwCAQEwgcUwgb4xCzAJ
BgNVBAYTAkRFMQ8wDQYDVQQIEwZIZXNzZW4xGjAYBgNVBAcTEUZyYW5rZnVydCBhbSBNYWlu
MSEwHwYDVQQKExhJbm5vdmF0aXZlIFNvZnR3YXJlIEdtYkgxHzAdBgNVBAsTFk5ldHdvcmsg
QWRtaW5pc3RyYXRpb24xIjAgBgNVBAMTGUlTRyBDZXJ0aWZpY2F0ZSBBdXRob3JpdHkxGjAY
BgkqhkiG9w0BCQEWC2luZm9AaXNnLmRlAgIC0DAJBgUrDgMCGgUAoIGxMBgGCSqGSIb3DQEJ
AzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTAyMDMwODA4MTIyOFowIwYJKoZIhvcN
AQkEMRYEFFx5xZsZvMWEOKoUH63jTdw03XHoMFIGCSqGSIb3DQEJDzFFMEMwCgYIKoZIhvcN
AwcwDgYIKoZIhvcNAwICAgCAMAcGBSsOAwIHMA0GCCqGSIb3DQMCAgFAMA0GCCqGSIb3DQMC
AgEoMA0GCSqGSIb3DQEBAQUABIGAJrRTNVKhJTswGJnNUSARM5Tssy7INSCm2TDCow1ItuJL
/ltY+/Eo4RTVyzDcUXPPBX8P8rI3WtMkxPO6PLmcE/ZTTa7eROXUpXfPPnNEv4wb5ty5uPhu
hd8bm8CALWx4i+LFNfejT2KTyc5H9RF02pr5UfkV0f2hTxTNUWQE4h4=
--------------msB943C623BE2B0E4E3135F8D9--