[Python-Dev] Re: [Python-checkins] python/dist/src/Mac/Include getapplbycreator.h,1.3,1.4 macdefs.h,1.11,1.12 macglue.h,1.61,1.62 pythonresources.h,1.27,1.28

Thomas Wouters thomas@xs4all.net
Tue, 10 Sep 2002 17:12:53 +0200


On Tue, Sep 10, 2002 at 05:32:49AM -0700, jackjansen@users.sourceforge.net wrote:

> Modified Files:
> 	getapplbycreator.h macdefs.h macglue.h pythonresources.h 
> Log Message:
> Added include guards and C++ extern "C" {} constructs. Partial fix for #607253.
> Bugfix candidate.

[..]

> *** getapplbycreator.h	19 May 2001 12:32:39 -0000	1.3
> --- getapplbycreator.h	10 Sep 2002 12:32:47 -0000	1.4

[..]

>   ******************************************************************/
> + #ifndef Py_GETAPPLBYCREATOR_H
> + #define Py_GETALLPBYCREATOR_H

This looks suspiciously like a bug. If you really do intend to #define
something different than you just checked against, you should add a comment
stating that this really isn't a typo of a very common idiom :)

I'm-not-dead--I-feel-fine-ly y'rs,
-- 
Thomas Wouters <thomas@xs4all.net>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!