[Python-Dev] Re: [Python-checkins] python/dist/src/Objects listobject.c,2.172,2.173

Jeremy Hylton jeremy at alum.mit.edu
Fri Dec 26 14:06:31 EST 2003


On Fri, 2003-12-26 at 14:05, jhylton at users.sourceforge.net wrote:
> Update of /cvsroot/python/python/dist/src/Objects
> In directory sc8-pr-cvs1:/tmp/cvs-serv32521
> 
> Modified Files:
> 	listobject.c 
> Log Message:
> Revert previous two checkins to repair test failure.
> 
> The special-case code that was removed could return a value indicating
> success but leave an exception set.  test_fileinput failed in a debug
> build as a result.

If there's some value to the optimization I just removed, let's discuss
it on python-dev.  I could have fixed the new code, but it seems a lot
of hairy new code with magic constants that only covered a few corner
cases.  The checkin message pointed to a python-list discussion that
didn't have much real evidence in it.

Jeremy





More information about the Python-Dev mailing list