[Python-Dev] Overly creative config in socketmodule.c

[Tim Peters]

Someone very recently checked in this change:

static PyObject*
socket_inet_aton(PyObject *self, PyObject *args)
{
#ifndef INADDR_NONE
#define INADDR_NONE (-1)
#endif

	/* Have to use inet_addr() instead */
	char *ip_addr;
#if 1
...
	if (inet_aton(ip_addr, &buf))
		return PyString_FromStringAndSize((char *)(&buf),
...						  sizeof(buf));

#else /* In case you don't have inet_aton() */
...
#endif
}

Now in case you were wondering,

#if 1
#else
#endif

isn't a robust way to do platform configuration <wink/arghghgh>.

Whoever did this, please back it out or do it right.  inet_aton doesn't
exist on Windows, so socketmodule.c no longer compiles there.