[Python-Dev] Vacation and possibly a new bug
Tue, 22 Jul 2003 18:42:47 -0400
The patch below fixes test_time on RedHat 6.2/Alpha. Since I don't
understand the code, I haven't the slighest clue if the patch is
correct or not. But I do know what (365 * 24 * 3600) is. :-)
I don't know what ((365 * 24 + 6) * 3600) is supposed to represent.
1 year + 6 hours in seconds. What's that?
I've copied Stuart Bishop on this message as I believe he wrote
all this code. The patches in http://python.org/sf/762934 haven't
made the tests pass.
I'm not real comfortable including this in 2.3. Although the
worst that should happen is that it gives incorrect results
(which may very well be happening now).
If this does get checked in while I'm away, you can verify
the test succeeds by going to this page:
The RedHat 6.2/Alpha host is asmodean. Click the red dot
in the asmodean row and python test column. Verify that
test_time no longer fails.
RCS file: /cvsroot/python/python/dist/src/Modules/timemodule.c,v
retrieving revision 2.138
diff -w -u -r2.138 timemodule.c
--- Modules/timemodule.c 1 Jul 2003 05:16:08 -0000 2.138
+++ Modules/timemodule.c 22 Jul 2003 22:36:35 -0000
@@ -600,7 +600,7 @@
#else /* !HAVE_TZNAME || __GLIBC__ || __CYGWIN__*/
-#define YEAR ((time_t)((365 * 24 + 6) * 3600))
+#define YEAR ((time_t)(365 * 24 * 3600))
struct tm *p;
long janzone, julyzone;