[Python-Dev] upgrading to zlib 1.2.1 for Windows

[Thomas Heller]

Jeremy Hylton <jeremy at alum.mit.edu> writes:

> I noticed that a new version of zlib was released last year.  1.2.0 came
> out in March through 1.2.1 in late November.  There are a lot of API
> changes and new DLL support, but the new code seems to work fine with a
> Python build.  That is, it compiles with minor changes to the build and
> the tests all pass.  Even if we don't change our code at all, inflate is
> about 20% faster and crc32 is about 50% faster.

Sounds good.  Note that we're not using the DLL.

> Shall we upgrade the Windows build to use this new version?  I have the
> changes made locally, but don't want to commit until people have had a
> chance to grab the new source.
>
"Tim Peters" <tim.one at comcast.net> writes:

> [Jeremy]
>> I noticed that a new version of zlib was released last year.  1.2.0
>> came out in March through 1.2.1 in late November.
>> ...
>> Shall we upgrade the Windows build to use this new version?  I have
>> the changes made locally, but don't want to commit until people have
>> had a chance to grab the new source.
>
> Which Windows build(s)?  If you mean the 2.4 VC7 Windows build, sure.  The
> VC6 build appears to be officially unsupported now, so unsure about that
> one.  If there's another kind of "security fix" gimmick in 1.2.0 or 1.2.1,
> then a backport to 2.3 maint would also be appropriate.

I've skimmed through the changelog, and noticed no such security fix.
So I suggest to change it for 2.4, but leave 2.3 alone.

Thomas