[Python-Dev] Re: Re: python/dist/src/Objects unicodeobject.c, 2.228, 2.229

Fredrik Lundh fredrik at pythonware.com
Fri Oct 15 17:32:39 CEST 2004


>>>Applied patch for [ 1047269 ] Buffer overwrite in PyUnicode_AsWideChar.
>>>
>>>Python 2.3.x candidate.
>>
>> why bother?
>>
>> the unicode object you're copying to holds size+1 characters, so all the
>> code does is copying an extra NULL character...  completely harmless.
>
> That's true for Py_UNICODE, but not necessarily for the
> wchar_t* buffer your dealing with.

oh, I missed that the patch modified two functions...  (and overwriting
the null char in FromWideChar is only a good idea if you're overwriting
it with another null character...)

</F> 





More information about the Python-Dev mailing list