[Python-Dev] Patches

"Martin v. Löwis" martin at v.loewis.de
Wed Oct 20 08:47:58 CEST 2004

Stephen J. Turnbull wrote:
> I think 10 is way too high; I would call it prohibitive for anyone who
> isn't already primarily a Python hacker.

Some kind of prohibition is necessary for the process of "pushing"
patches. If too many people actually perform the procedure, I may
not be able to keep my promise of giving their patches more attention.

Notice that this is my own, private procedure - the condition under
which *I* will make my volunteer time available. Other core developers
may have different procedures, such as giving such requests moderate
priority, trying to review the patches right away, or completely
ignoring such requests entirely (I believe the majority of people
with commit access falls in that category, as only a small fraction
of committers commits SF patches regularly).

People who don't want to use that procedure don't need to at all.
There is apparently a constant backlog of 200..300 patches. Patches
that look more important to regular reviewers will get attention,
patches that somehow seem doubtful will get skipped over - over and
over again. If you want to push one of these patches, and you don't
want to use the procedure of guaranteed review that I promise, you
can still use the begging procedure that most people come up with.

> I agree it should be more than 1 for 1 for several reasons, but I'd be
> willing to bet you get excellent results from 3:1 or even 2:1.  Even
> if you think that risks being a burden on your time, since you've had
> no takers yet (and it's been a while since the last time I saw your
> proposal), I'd say that lowering the "price" to 5:1 is a reasonable
> idea, and not very risky.  You can always raise the price again if you
> get 50 useful reviews by next Tuesday.<wink>

That might be an option indeed. So, Oleg, as a special offer, I will
do this at a 5:1 ratio :-)


More information about the Python-Dev mailing list